RBI-editor version 2

[nightwulf]

Just played it in Nester (nester public beta 4, from nester.dranalli.com) in single player mode, still stopped at 10 run slaughter...

Have you gotten it to work in 1 player mode at all?

See the attached picture. Using Nester public beta 4, in 1-player mode. I playing as St. Louis, pitching down the middle to San Francisco, and letting them run the bases. While there's no means in this emulator for me to easily confirm that 200 is actually the number the game will be called at, it's definitely not stopping at 10.

Is there some game genie setting or something you're turning on?  Or does it just not work in single player mode (vs. computer)?

Some brainstorms without thinking:

There is more than one place to set the slaughter, perhaps as a combo of two fields?

The entire byte of this address isn't used for the slaughter?

Slaughter for 1P, 2P and/or CPU are in different places?

There is a bounds check on the slaughter, causing it to ignore a number that is too large?

This has nothing to do with Game Genie whatsoever ...

The relevant statements are located in RAM at B550 (B560 in ROM, or 1B560 in 256k ROM). The same block of code is used regardless of game type (1p/2p/watch), as shown by setting breakpoints and watching execution in all three modes. The check is a simple CMP (compare with accumulator) operation; it's not a matter of not using the whole byte or a bounds check or anything else. For the benefit of Gantry or anyone else unfortunate enough to be familiar with assembler ...

$B550:C9 0A     CMP #$0A
$B552:B0 01     BCS $B555
$B554:60        RTS

When this code is executed, the accumulator currently holds the number of away team runs subtracted from the number of home team runs (see B53C-B542). That number is compared with 0A (10 decimal), and the subroutine is exited if the difference is not greater than or equal to 0A. The editor changes the value at B551 to whatever number is specified by the user, or changes B550/B551 to CLC/NOP if the user enters zero.

Nightwulf

[Gantry]

$B550:C9 0A    CMP #$0A
$B552:B0 01    BCS $B555
$B554:60        RTS

When this code is executed, the accumulator currently holds the number of away team runs subtracted from the number of home team runs (see B53C-B542). That number is compared with 0A (10 decimal), and the subroutine is exited if the difference is not greater than or equal to 0A. The editor changes the value at B551 to whatever number is specified by the user, or changes B550/B551 to CLC/NOP if the user enters zero.

Confirmed the game does end after 10 runs for me as well...

I did the opposite as you, and this is likely where the issue lies.  I had the away team (batting first) take a 10 run lead and struck out the home team.  The check for the slaughter should take place here at the end of the bottom of the inning.  

Is there where this code snippet takes place or is this part checked after every AB in the bottom of the inning?  

If you still can't reproduce this error, I'll play with the RAM, but I haven't touched any code in awhile and you can likely find the issue before I figure out how to watch RAM again...

Again (in case I didn't make sense), take a 10 run lead with the top of the inning and see what happens.  The game should go to the 2nd inning, but it ended for me...

[Gantry]

Now I'm confused...  I just opened the attached file of Dryden's on this forum post and I see 0A for B561h - nightwulf are you checking his emailed file on the one on the forum?

[nightwulf]

Now I'm confused...  I just opened the attached file of Dryden's on this forum post and I see 0A for B561h - nightwulf are you checking his emailed file on the one on the forum?

The relevant statements are located in RAM at B550 (B560 in ROM, or 1B560 in 256k ROM).

Nightwulf

[Gantry]

Whoops, didn't look at the ROM size.  Were you able to reproduce the error when the away team has the lead?  

And what emu do you use to dump/watch ram again?

[Gantry]

PS - 0B5A0 (1b5A0 in 256k) has the same instruction "C9 0A"

I'll test it out...

[Gantry]

In Dryden's ROM, changing the value at 1B5A1 fixed the issue.  So B561 must be the slaughter limit for the home team and B5A1 is for the away team...

[Dryden]

Thanks, guys, for the help with this - 'tis much appreciated.

Night- any plans to update the editor to cover both cases?

[nightwulf]

Bah, was playing a game in fceud watching for something to read the number of runs once the away team was ahead by more than 10. Yeah, the block of code immediately following the one modified is almost identical. The first block runs any time a run is scored, so maybe the second runs between innings (to catch the away team being ahead)? I dunno, not worried about figuring it out atm.

New version of the build routine is up, and addresses this issue. Thanks for  bringing it to my attention.

Nightwulf

[Gantry]

The first block runs any time a run is scored, so maybe the second runs between innings (to catch the away team being ahead)?

That's gotta be it, since the away team has to let the home team play a full inning for "last wraps"  

Or is it last raps?

[nightwulf]

One problem I have run into is sometimes, not all the time which makes it weird, but sometimes when you put in a number for a team name in the attract name and the newspaper name, like 84 tigers,  it causes the rom to be unable to save.

I was also unable to reproduce this error. By "unable to save," are you referring to saving the ROM on the server, or downloading it? Can you give specific examples ("84 tigers" saved fine for me) which produce the error you describe?

Thanks in advance.

Nightwulf

[Felonious Gunk]

I'm having minor problems trying to get the confuddled thing to work.  I saved my edits, but I can't reload them.  Proably my screwy computer being dickish about scripts (Win 98/IE6[Problem #1], before you ask)

[nightwulf]

I'm having minor problems trying to get the confuddled thing to work.  I saved my edits, but I can't reload them.  Proably my screwy computer being dickish about scripts (Win 98/IE6[Problem #1], before you ask)

Sorry, I ran into a bunch of problems with file access permissions. I thought I had all the usernames corrected, but apparently I missed yours.

The problem should be fixed now, but if it's not, send me a private message with your username and I'll make sure I see to it.

Nightwulf

[Felonious Gunk]

I will, but I still think it's mostly my piece of shit computer.  I'd know for a fact it was if I tried to load and got a random crash or BSOD.  Time for new memory, or a new computer...  

[ultimate7]

I'm trying to import a tab-delemited file and into RBI-editor and am not having any success.  None of the stats are being uploaded.  I'm sure it's something I'm doing wrong.  Has any one else tried this feature?  Thanks!

Try loading any existing ROM into the editor (default NES, etc.) and export it. Make sure the file you're trying to upload matches the format of the file exported.

Nightwulf

Bump for me, I'm trying to figure out the layout and don't want to have to keep searching for this thread if I need it.