Forum software update

[Attezzobal]

I can't help nearly as much as Gantry. All I know is, it's happening on my work comp, using IE 4.0, and I believe I have java script enabled (I'm not at work at the moment, so I can't check).

[Gantry]

IE 4.0?  What version of Windows are you running at work?  You guys are sorely due for an upgrade if that is what you are actually running...

[Gantry]

Just tested Safari (based off Konqueror) and that works as well.  I uninstalled the Tab Mix Plus extension on my firefox and it did not help.  I am 80% certain that clicking quote went to quick reply on this same laptop via firefox yesterday.  The only difference is that I was at work, I don't think I've installed anything new since then...

I do know that Adblock has been acting goofy for me lately on multiple PCs - some aviators are getting blocked and I can't see the list of blockable elements.  Wonder if that is causing any issues, I'm afraid to uninstall but I think I can save my list first...

[BeefMaster]

I'm seeing it go into ful reply mode on Firefox 1.0.7, on both my home and work computers (XP Home and XP Pro).  It previously went to quick reply on both systems, and I don't believe I've changed any settings on either machine.

Minor nitpick - the "Dee-Nee forums" graphic at the top of the page use to be a link to the main homepage, which I found useful when I was looking at an RBI topic and wanted to make a quick check of rosters or something (I noticed this morning when I was going to check whether Joyner had an existing Hall of Shame entry, given today's steroid revelation).  I don't know whether it was an intentional change, and it's not a big deal, but it's something I noticed.

[ultimate7]

Minor nitpick - the "Dee-Nee forums" graphic at the top of the page use to be a link to the main homepage, which I found useful when I was looking at an RBI topic and wanted to make a quick check of rosters or something

Yes, I use this too and noticed it yesterday, and had to type in the url instead.

[nightwulf]

I can't help nearly as much as Gantry. All I know is, it's happening on my work comp, using IE 4.0, and I believe I have java script enabled (I'm not at work at the moment, so I can't check).

Yeah, like Gantry said, I'm a bit shocked that anyone's using IE4 anymore. But it did work on your work computer before the upgrade, yes?

Minor nitpick - the "Dee-Nee forums" graphic at the top of the page use to be a link to the main homepage ...

Fixed.

[Gantry]

My upstairs machine with FF 1.5rc1 does infact goto quick reply when quoting.  This machine also has adblock and Tab Mix, so the plot thickens.  I'll browse the SMF forums and see if anyone else has chimed in...

[nightwulf]

I'm running 1.5RC1 with Adblock also. I did make a couple changes to the code that handles displaying a thread (and how "Quick Reply" is handled), but it wasn't what I was looking for (which was "Additional Options" on the post page), so I removed my changes. As a precaution, I trashed that file and replaced it with the original from the upgrade package, so check it out again unless I screwed something up.

[Gantry]

No changes with quotes going to full reply on the iBook...

When did you implement and remove these changes? 

[nightwulf]

I just grabbed an original and copied it to Sources at 10:44 am server time. My failed attempt at changing it would've been in the wee hours on the night I did the upgrade.

[nightwulf]

There's an onclick handler for the "quote" button as such:

onclick="if (!currentSwap) doQuote(184289); else window.location.href = this.href; return false;"

Are you getting any Javascript errors? With Firefox, open up Tools -> JavaScript Console, hit the "Clear" button, then try hitting the "quote" button again and see if anything comes up in the Javascript console.

[Gantry]

Booyah!

"Error: getXMLDocument is not defined
Source File: http://forums.dee-nee.com/index.php?topic=10248.new;boardseen#new
Line: 838"

[Gantry]

Similar error with FF 1.07:

Error: getXMLDocument is not defined
Source File: http://forums.dee-nee.com/index.php?topic=10248.new#new
Line: 903

[Big Hath]

Minor nitpick - the "Dee-Nee forums" graphic at the top of the page use to be a link to the main homepage, which I found useful when I was looking at an RBI topic and wanted to make a quick check of rosters or something

Yes, I use this too and noticed it yesterday, and had to type in the url instead.

I was always confused as to why clicking on the "Dee Nee Forums" link at the top sent me to the homepage and not the Forums page.

[Gantry]

Because people want to get to dee-nee proper from the forums, I do it all the time.  There are multiple ways already to get to the main forum page from anywhere on the forums...

[nightwulf]

Ok, the function getXMLDocument is located in /Themes/default/script.js, which is loaded on every Display page. Try wiping the Javascript console again then reload any thread display. Is script.js crashing somewhere?

[Gantry]

Ok, the function getXMLDocument is located in /Themes/default/script.js, which is loaded on every Display page. Try wiping the Javascript console again then reload any thread display. Is script.js crashing somewhere?

Nothing is crashing anywhere, no errors in the Javascript Console.  Not only that, quotes suddenly go to quick reply now.  Did you change anything yet? 

[Gantry]

Ok, the function getXMLDocument is located in /Themes/default/script.js, which is loaded on every Display page. Try wiping the Javascript console again then reload any thread display. Is script.js crashing somewhere?

Nothing is crashing anywhere, no errors in the Javascript Console.  Not only that, quotes suddenly go to quick reply now.  Did you change anything yet? 

I think reloading a page before using the "quote" button is what fixes the problem.  Quote was going to a full reply on my PC until I reloaded the page, now it properly goes to quick reply.  A bug somewhere in SMF?

[Big Hath]

Because people want to get to dee-nee proper from the forums, I do it all the time.  There are multiple ways already to get to the main forum page from anywhere on the forums...

oh, I completely understand that - perhaps it should just say Dee Nee and no "Forums"

[nightwulf]

Nothing is crashing anywhere, no errors in the Javascript Console.  Not only that, quotes suddenly go to quick reply now.  Did you change anything yet? 

I think reloading a page before using the "quote" button is what fixes the problem.  Quote was going to a full reply on my PC until I reloaded the page, now it properly goes to quick reply.  A bug somewhere in SMF?

I replaced Display.template.php at 10:44 am server time, as mentioned above, but nothing I touched in the first place had to do anything with the loading of script.js. Best guess is that it's a bug in SMF, but I have no idea what it would be yet. I'm gonna try various other browsers and OSes I have access to and see if I can encounter it myself. Without being able to reproduce the bug myself, it's about impossible to try to fix it.