Site may be flaky

[Gantry]

Current issues with "all SSL" for Dee-Nee

• Tapatalk needs to be deleted and re-added
• Old YouTube vids don't embed

[nightwulf]

Appears we have an avatar issue ... the forum software is prepending the forum avatar directory URL in front of external URLs. That is, it's using

Code Select Expand

http://forums.dee-nee.com/avatars/http://nightwulf.rbicentral.com/nightwolf-sel.gif for my avatar URL. Not seeing where to fix this in settings and not sure how switching to https would cause this ...

[Gantry]

Been fucking with it as the avatar was the only thing loading via http and not https.  Was hand-editing the php files but I think I changed them all back after I found the proper spot to chnage https avatar loads in the admin settings.  See if it's still happening. 

[Gantry]

Now it's back to "partially encrypted" jesus christ  - how can it be so hard to make this software load everything via https?

[Gantry]

OK now fully https but see if it's happening again.  The culprit may be line 3236 of Subs.php wulf, copy/pasted that from an SMF community post. so maybe it's not doing something properly.  If I don't change that line the main avatar doesn't load https

[nightwulf]

Admin -> forum -> attachments and avatars -> avatar settings to specify the default URL; it's showing https now.

If you gave me ssh access after moving the server home, I'm not aware of it, so unable to look at Subs.php. Using the default Subs, and https specified in admin settings as above, no avatars are loaded? What's the HTML look like in the img tag?

Didn't think of this before, but you might run into mixed content warnings. That is, if the whole page is https but it's loading my avatar from (http) nightwulf.rbicentral.com, that might generate a "do you want to load only the secure content" popup. The real answer here might be to enable the feature that downloads external avatars to the server and then serves locally.

[Gantry]

Yeah I changed it to https but I still need to make the Subs.php change here for it to work:

http://www.simplemachines.org/community/index.php?topic=485755.msg3401177#msg3401177

I'll set you up with an account and text the login info shortly. 

[Gantry]

I didn't look at mixed content enough but I think the error that bug the users are only if you mix http & https within your own domain.  Otherwise no forum/blog/whatever website that lets you load otehr peoples images, youtube, etc would be usable via https without really bugging the user. 

[Reds]

NERD ALERT

[Gantry]

Avatars set to https in admin and loading the site fully https, changed Subs.php back to original code, but the edited one is still there and commented out.  Avatars still fucked up if linked to outside, wonder if I edited something and forgot about it. 

[nightwulf]

Copied the whole block of code dealing with avatars to a text editor to properly format it so I can fkn read it. People bitch about perl being hard to read, then they scribble out PHP without any proper use of braces and rely on seemingly random use of tabs to show program flow. HATE.

[nightwulf]

I don't think the lines you're modifying in Subs.php are the issue; think that's for the avatar of the user rather than the poster. Looking through Display.php, might be a project for tomorrow ...

[Gantry]

I think you are right about that, my avatar giving me issues with http and not https was my own. 

[Gantry]

The "Jump to" area to pick your board also acting flaky

[nightwulf]

It's gotta be in Load.php:

Code Select Expand

'image' => $profile['avatar'] == '' ? ($profile['id_attach'] > 0 ? '<img class="avatar" src="' . (empty($profile['attachment_type']) ? $scripturl . '?action=dlattach;attach=' . $profile['id_attach'] . ';type=avatar' : $modSettings['custom_avatar_url'] . '/' . $profile['filename']) . '" alt="" />' : '') : (stristr($profile['avatar'], 'https://') ? '<img class="avatar" src="' . $profile['avatar'] . '"' . $avatar_width . $avatar_height . ' alt="" />' : '<img class="avatar" src="' . $modSettings['avatar_url'] . '/' . htmlspecialchars($profile['avatar']) . '" alt="" />'),

[Gantry]

Don't ahve an ssh session but check modify date on that file, maybe I manually added some https in there, but I'm pretty sure I backed up the original file and copied back when it didn't help.

[nightwulf]

Actually I just changed (stristr($profile['avatar'], 'https://') to http instead of https and the avatars are back. I need to figure out exactly what that may break, or if it even makes sense, but avatars came back. Will figure all that out tomorrow.

[Reds]

Avatars seem bigger.  Is that just me?

[nightwulf]

Still hardcoded to 75x75, so just you. I think.

[Kane]

Avatars seem bigger.  Is that just me?

Did you shave around the edges?